Conversation
duncanista
reviewed
Jan 13, 2026
Contributor
Author
There was a problem hiding this comment.
The dd-octo folks claim to do a periodic review of these: https://datadoghq.atlassian.net/wiki/spaces/SECENG/pages/5138645099/User+guide+dd-octo-sts#%3Abest%3A-Best-practices
duncanista
reviewed
Jan 13, 2026
| permissions: | ||
| packages: write | ||
| metadata: read No newline at end of file | ||
| actions: write No newline at end of file |
Contributor
There was a problem hiding this comment.
add line to avoid eol lint error
duncanista
reviewed
Jan 13, 2026
Contributor
There was a problem hiding this comment.
nit: do we want the scripts to be inline or do we want them in a separate file?
Contributor
Author
There was a problem hiding this comment.
I have absolutely no opinion on this! Happy to move them wherever y'all prefer, though if you want serverless-init in as little of the repo as possible, then inline makes sense
duncanista
approved these changes
Jan 13, 2026
Contributor
duncanista
left a comment
duncanista
left a comment
There was a problem hiding this comment.
LGTM – left some comments
Lewis-E
force-pushed
the
lewis/SVLS-8070/serverless-init-rc-images-from-gitlab
branch
from
52bc98f to
215edba
Compare
Lewis-E
force-pushed
the
lewis/SVLS-8070/serverless-init-rc-images-from-gitlab
branch
from
3c1cca8 to
63001b8
Compare
Lewis-E
deleted the
lewis/SVLS-8070/serverless-init-rc-images-from-gitlab
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Testing